-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add tailwindcss and replace oc-m/p classes #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f90eaa to
8135876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Tailwind CSS and replaces the existing custom margin and padding utility classes with Tailwind equivalents. The change aims to modernize the styling system by transitioning from custom oc-m and oc-p classes to Tailwind's standardized utility classes.
Key Changes:
- Added Tailwind CSS configuration and integration to the build system
- Replaced custom margin/padding classes (
oc-m-*,oc-p-*) with Tailwind equivalents (m-*,p-*) - Updated test snapshots to reflect the new class names
Reviewed Changes
Copilot reviewed 237 out of 238 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Added Tailwind CSS plugin and build configuration |
| packages/web-runtime/src/tailwind.ts | Entry point for Tailwind CSS imports |
| packages/web-runtime/src/tailwind.css | Tailwind CSS configuration with custom spacing |
| Various .vue files | Updated class names from custom utilities to Tailwind equivalents |
| Test snapshot files | Updated snapshots to reflect new Tailwind class names |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
08bf043 to
ccb831f
Compare
Also replaces the `oc-m/p-rm` classes with their Tailwind equivalent.
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 💪
ccb831f to
9c87de6
Compare
feat: add tailwindcss and replace oc-m/p classes
Introduces Tailwind CSS.
Also replaces our margin and padding utility classes with Tailwind ones. The overall feel and look of the UI should be roughly the same as before. Maybe you'll find some minor differences in spacing due to them being more streamlined and many parts still missing.
The next step is to remove all margins and paddings from custom css and replace them with either Tailwind utility classes or by moving them to Tailwind's layer system.
The design-system docs also need some more work, I didn't get it to run well with Tailwind so far. Needs some more investigation and a follow-up PR.
Migration
oc-m-xs>m-1oc-m-s>m-2oc-m-m>m-4oc-m-l>m-6oc-m-xl>m-12oc-m-xxl>m-24oc-m>m-4oc-m-rm>m-0refs #937