-
Notifications
You must be signed in to change notification settings - Fork 25
fix extension registry stable order #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the extension registry ordering issue by ensuring applications are loaded and registered in a stable order. The change separates the loading phase (which remains parallel for performance) from the building/registration phase (which now happens sequentially to maintain order).
Key changes:
- Split application handling into separate
loadApplicationandbuildApplicationfunctions - Application script loading remains parallel but building/registration now happens sequentially
- Application initialization continues to run in parallel after all apps are built
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/web-runtime/src/container/application/index.ts |
Splits application handling into separate load and build functions |
packages/web-runtime/src/container/bootstrap.ts |
Updates initialization logic to use new two-phase approach for stable ordering |
packages/web-runtime/tests/unit/container/bootstrap.spec.ts |
Updates test mocks to reflect the new function separation |
packages/web-pkg/src/composables/actions/files/useFileActionsToggleHideShare.ts |
Fixes typo in error message |
packages/web-pkg/src/components/SideBar/SideBar.vue |
Adds conditional rendering logic and styling for sidebar panels |
dev/docker/opencloud/csp.yaml |
Adds OpenStreetMap domain to CSP configuration |
packages/web-pkg/src/composables/actions/files/useFileActionsToggleHideShare.ts
Show resolved
Hide resolved
60ee148 to
280c31c
Compare
280c31c to
62e06e7
Compare
Description
While reviewing opencloud-eu/web-extensions#166 we found out that the order of applications during application loading is not stable. Instead of coming up with a sorting/weight concept we've decided to just maintain a stable order. This PR does that with the least possible performance impact:
initializehook on all applications happens in parallel againHow Has This Been Tested?
Manually and with the existing unit tests.
Types of changes