Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jul 24, 2025

related #891
https://github.com/user-attachments/assets/3025dbee-d618-40ca-910d-d6980a8d352c

Add Mobile E2E Testing Support

This PR introduces comprehensive mobile and tablet testing capabilities for our e2e test suite.

Overview

Mobile view testing is now supported with multiple device configurations running in parallel within a single e2e-mobile-view pipeline.

Devices

Test Suite Browser Device Description
mobile-chromium Chromium Pixel 5 Android mobile testing
mobile-webkit WebKit iPhone 12 iOS mobile testing
ipad-chromium Chromium iPad Pro 11 iPad testing with Chromium
ipad-landscape-webkit WebKit iPad Pro 11 iPad landscape testing with Safari

Localy running:

  • pnpm test:e2e:mobile-chromium
  • pnpm test:e2e:mobile-webkit
  • pnpm test:e2e:ipad-chromium
  • pnpm test:e2e:ipad-safari
    or
  • pnpm test:e2e:mobile-parallel # Run all mobile tests in parallel

test output

Since we are running tests in parallel, I have adjusted the test results output to separate them by device.

Screenshot 2025-07-29 at 14 52 20

Again issue in the webkit after closing text editor. similar was in the #954

Screenshot 2025-07-29 at 15 09 01

@ScharfViktor ScharfViktor force-pushed the mobile-view-tests branch 7 times, most recently from 14c6dd7 to 57aff48 Compare July 29, 2025 12:54
@ScharfViktor ScharfViktor marked this pull request as ready for review July 29, 2025 12:54
Copilot AI review requested due to automatic review settings July 29, 2025 12:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces comprehensive mobile E2E testing support by adding device-specific test configurations for mobile and tablet devices including Android (Pixel 5), iOS (iPhone 12), and iPad Pro 11 in both portrait and landscape orientations.

Key changes include:

  • Added mobile device browser configurations with proper viewport and user agent settings
  • Created mobile-specific test scenarios and conditional logic for mobile UI interactions
  • Implemented parallel test execution with separate logging for each device configuration

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/e2e/support/objects/app-files/resource/actions.ts Added mobile-specific UI interaction logic for Collabora editor and upload workflows
tests/e2e/support/environment/actor/shared.ts Configured device emulation settings for mobile and tablet browsers
tests/e2e/cucumber/features/mobile-view/smoke.feature Created comprehensive mobile test scenario covering file operations and viewers
tests/e2e/cucumber/environment/index.ts Added browser launch configurations for mobile device testing
package.json Added npm scripts for individual and parallel mobile test execution
.woodpecker.star Implemented CI pipeline for mobile E2E testing with proper service dependencies

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We also should add tests for the recently added bottom drawer at some point. But it makes sense to wait until #1017 is done.

@ScharfViktor ScharfViktor merged commit b0b24a0 into main Jul 30, 2025
29 checks passed
@ScharfViktor ScharfViktor deleted the mobile-view-tests branch July 30, 2025 07:31
@openclouders openclouders mentioned this pull request Jul 30, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants