-
Notifications
You must be signed in to change notification settings - Fork 25
Mobile view tests #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile view tests #1006
Conversation
14c6dd7 to
57aff48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces comprehensive mobile E2E testing support by adding device-specific test configurations for mobile and tablet devices including Android (Pixel 5), iOS (iPhone 12), and iPad Pro 11 in both portrait and landscape orientations.
Key changes include:
- Added mobile device browser configurations with proper viewport and user agent settings
- Created mobile-specific test scenarios and conditional logic for mobile UI interactions
- Implemented parallel test execution with separate logging for each device configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/actions.ts | Added mobile-specific UI interaction logic for Collabora editor and upload workflows |
| tests/e2e/support/environment/actor/shared.ts | Configured device emulation settings for mobile and tablet browsers |
| tests/e2e/cucumber/features/mobile-view/smoke.feature | Created comprehensive mobile test scenario covering file operations and viewers |
| tests/e2e/cucumber/environment/index.ts | Added browser launch configurations for mobile device testing |
| package.json | Added npm scripts for individual and parallel mobile test execution |
| .woodpecker.star | Implemented CI pipeline for mobile E2E testing with proper service dependencies |
57aff48 to
a0a9ff6
Compare
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We also should add tests for the recently added bottom drawer at some point. But it makes sense to wait until #1017 is done.
related #891
https://github.com/user-attachments/assets/3025dbee-d618-40ca-910d-d6980a8d352c
Add Mobile E2E Testing Support
This PR introduces comprehensive mobile and tablet testing capabilities for our e2e test suite.
Overview
Mobile view testing is now supported with multiple device configurations running in parallel within a single
e2e-mobile-viewpipeline.Devices
Localy running:
pnpm test:e2e:mobile-chromiumpnpm test:e2e:mobile-webkitpnpm test:e2e:ipad-chromiumpnpm test:e2e:ipad-safarior
pnpm test:e2e:mobile-parallel# Run all mobile tests in paralleltest output
Since we are running tests in parallel, I have adjusted the test results output to separate them by device.
Again issue in the webkit after closing text editor. similar was in the #954