fix: sidebar actions panel design #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates sidebar actions panel design by standardizing styling across multiple components. The changes convert three Vue components from Options API to Composition API and centralize their CSS styling into a shared design system class.
- Convert Vue components from Options API to Composition API syntax using
<script setup> - Replace component-specific CSS with a shared
sidebar-actions-panelclass - Remove duplicated styling and the
oc-roundedclass from action menu items
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SpaceActions.vue | Convert to Composition API and apply shared sidebar styling class |
| FileActions.vue | Convert to Composition API and apply shared sidebar styling class |
| ActionsPanel.vue | Convert to Composition API and apply shared sidebar styling class |
| ActionsPanel.spec.ts | Add ActionMenuItem mock to handle component changes |
| helper.scss | Add centralized .sidebar-actions-panel styling |
packages/web-app-admin-settings/tests/unit/components/Spaces/SideBar/ActionsPanel.spec.ts
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/sidebar-actions-panel-design
branch
from
efd4240 to
1b81c98
Compare
JammingBen
force-pushed
the
fix/sidebar-actions-panel-design
branch
from
1b81c98 to
f3e7776
Compare
AlexAndBear
approved these changes
Jul 24, 2025
openclouders
pushed a commit
that referenced
this pull request
Jul 24, 2025
…design fix: sidebar actions panel design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #997.