fix: show explicit error message, when trying to upload space image but quota is exceeded #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut quota is exceeded
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling for space image upload operations by providing specific error messages when storage quota is exceeded. The changes add explicit handling for HTTP 507 (Insufficient Storage) errors to give users clear feedback instead of generic error messages.
Key changes:
- Added specific error handling for quota exceeded scenarios (HTTP 507 status code)
- Improved error message consistency between space icon and space image operations
- Enhanced user experience with descriptive error messages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| useSpaceActionsSetIcon.ts | Added HttpError import and specific handling for 507 status code with descriptive error message for space icon uploads |
| SpaceImageModal.vue | Added HttpError import, reordered error cleanup logic, and implemented specific 507 error handling for space image uploads |
packages/web-pkg/src/composables/actions/spaces/useSpaceActionsSetIcon.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/spaces/useSpaceActionsSetIcon.ts
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JammingBen
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes