Skip to content

Conversation

@dschmidt
Copy link
Contributor

@dschmidt dschmidt commented Oct 22, 2025

Copilot AI review requested due to automatic review settings October 22, 2025 11:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the worker URL import in the unzip action composable by replacing the relative path import with a direct package import. The change simplifies the import statement and removes the need for runtime URL construction using urlJoin and dirname.

  • Replaced relative file path import with direct package import using Vite's ?worker&url syntax
  • Removed the now-unnecessary runtime URL construction logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen changed the title refactor(maps): import worker url refactor(unzip): import worker url Oct 22, 2025
@JammingBen JammingBen added the Type:Maintenance E.g. technical debt, packaging, etc. label Oct 22, 2025
@JammingBen
Copy link
Contributor

Needs a new extension-sdk alpha release after opencloud-eu/web#1412 has been merged.

@dschmidt dschmidt force-pushed the refactor/import-worker-url branch from 8aa7830 to 6bd6759 Compare October 23, 2025 08:12
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JammingBen JammingBen merged commit 4fa5f09 into opencloud-eu:main Oct 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants