Skip to content

Conversation

@butonic
Copy link

@butonic butonic commented Mar 10, 2025

fixes the etag propagation for trash items
part of opencloud-eu/opencloud#281

❯ make test-acceptance-api \
   TEST_SERVER_URL=https://opencloud-server:9200 \
   BEHAT_FEATURE=tests/acceptance/features/coreApiWebdavEtagPropagation2/restoreFromTrash.feature
[...]
The following tests were skipped because they are tagged @skip:
runsh: Total 8 scenarios (8 passed, 0 failed)
runsh: There were no unexpected failures.
runsh: There were no unexpected success.

and make test passes.

@aduffeck returning the recycleNode smells. but the propagation will call Parent() on it anyway. however ... I'm not 100% sure the parint will always be the target destination parent and not the old trash parent. I'll try if I can add that to the tests ... affter lunch

butonic added 2 commits March 10, 2025 13:16
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@aduffeck aduffeck merged commit 7893bc4 into main Mar 10, 2025
@aduffeck aduffeck deleted the always-propagate-on-trash-restore branch March 10, 2025 16:03
@openclouders openclouders mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants