Skip to content

Conversation

@dragonchaser
Copy link

@dragonchaser dragonchaser commented Nov 25, 2025

supersedes #383

Fixed opencloud-eu/opencloud#1671

Checklist:

  • Sharing to/from OpenCloud [patched] works
  • Sharing to/from oCIS [patched] works
  • Sharing to/from CERNBox works
  • Consistent invite and share payloads
  • Make sure incoming federated user uuid doesn't collide with internal users
  • Backward compatibility?

Based on the:

The issue I raised has happened.

The combined goal of those 2 PRs is:

  1. Avoid collision from remote users
  2. Preserve the local user IdP info when federating by constructing the opaque_id = user@idp, which is completely fine based on OCM spec, even without the base64

The issue:

  • OpenCloud should only base64 encode INCOMING user contact information, not OUTGOING (changed in 4933)

P.S. Tests are probably still outdated or wrong

MahdiBaghbani and others added 3 commits November 25, 2025 15:32
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Co-authored-by: Roman Perekhod <2403905@gmail.com>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
@dragonchaser dragonchaser force-pushed the fix-ocm branch 2 times, most recently from fb12f60 to be64ceb Compare November 26, 2025 09:17
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
@dragonchaser dragonchaser marked this pull request as ready for review November 26, 2025 10:31
@dragonchaser dragonchaser changed the title [WIP] Fix ocm fix(ocm): OCM Specification Compliance Nov 26, 2025
@dragonchaser dragonchaser requested a review from butonic November 26, 2025 10:44
@butonic butonic merged commit 362c9c9 into opencloud-eu:main Nov 26, 2025
19 checks passed
@dragonchaser dragonchaser deleted the fix-ocm branch November 26, 2025 13:50
@micbar
Copy link

micbar commented Nov 26, 2025

@dragonchaser Please always add a Type label for the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenCloud cannot receive OCM shares from other EFSS

4 participants