Skip to content

Conversation

@butonic
Copy link

@butonic butonic commented Nov 24, 2025

Active Directory stores objectGUID with mixed endianness:

  • The first 3 components (time-low, time-mid, time-high) are stored in little-endian
  • The last 2 components (clock-seq and node) are stored in big-endian

When the attribute is 'objectguid' (and IDIsOctetString==true) we now swap the byte order for the first three components before encoding.

@butonic butonic self-assigned this Nov 24, 2025
@butonic butonic requested review from micbar and rhafer November 24, 2025 11:58
@butonic butonic marked this pull request as draft November 24, 2025 12:30
@butonic
Copy link
Author

butonic commented Nov 24, 2025

I'll update this to align with the implementation in https://github.com/opencloud-eu/opencloud/blob/main/services/graph/pkg/identity/ldap.go

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the handler-objectguid-endianness branch from 08c6f57 to 297138c Compare November 24, 2025 12:44
@butonic butonic marked this pull request as ready for review November 24, 2025 12:44
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Nov 24, 2025
@butonic butonic moved this from Qualification to In Progress in OpenCloud Team Board Nov 24, 2025
@butonic butonic merged commit 4acb0bf into main Nov 25, 2025
19 checks passed
@butonic butonic deleted the handler-objectguid-endianness branch November 25, 2025 07:26
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenCloud Team Board Nov 25, 2025
@openclouders openclouders mentioned this pull request Nov 25, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants