fix: restore revision after negative post-processing outcome #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
tested in: opencloud-eu/opencloud#1868 |
butonic
reviewed
Nov 20, 2025
When the postprocessing for a file results in e.g. the "PPOutcomeDelete" state it is not enough to just restore the metadata. On posixfs we also need to restore the file blob itself as another concurrent upload might have written it's blob already into the revison node that was created during the postprocessing of the to be reverted upload. Closes cs3org#1871
The filepermission for the uploaded blob included the 'executable (x)' permission. We don't need that.
butonic
reviewed
Nov 20, 2025
butonic
reviewed
Nov 20, 2025
butonic
reviewed
Nov 20, 2025
butonic
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the postprocessing for a file results in e.g. the "PPOutcomeDelete" state it is not enough to just restore the metadata.
On posixfs we also need to restore the file blob itself as another concurrent upload might have written it's blob already into the revison node that was created during the postprocessing of the to be reverted upload.
Closes cs3org#1871