Skip to content

Add a hybrid metadatabackend #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
butonic merged 9 commits into from
Feb 25, 2025
Merged

Add a hybrid metadatabackend #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d16a864
Add a hybrid metadatabackend
aduffeck Feb 20, 2025
dd5183e
Also offload arbitrary metadata. Check for size threshold before writing
aduffeck Feb 24, 2025
dc16dd9
fix offloading
butonic Feb 25, 2025
6e2e09d
drop unused List()
butonic Feb 25, 2025
06f3621
actually default to hybrid metadata for posix only
butonic Feb 25, 2025
c5665c7
fix removing offloaded attributes, return noattr err
butonic Feb 25, 2025
55520fc
Fix removing non-offloaded attributes, add unit tests
aduffeck Feb 25, 2025
9048e0e
Return a proper xattr.Error when an attribute is not found. add tests.
aduffeck Feb 25, 2025
2a2f900
Also return an xattr.Error when removing a non-existent attribute
aduffeck Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/storage/fs/posix/options/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ func New(m map[string]interface{}) (*Options, error) {
return nil, err
}

// default to hybrid metadatabackend for posixfs
if _, ok := m["metadata_backend"]; !ok {
m["metadata_backend"] = "hybrid"
}

do, err := decomposedoptions.New(m)
if err != nil {
return nil, err
Expand Down
16 changes: 13 additions & 3 deletions pkg/storage/fs/posix/posix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"context"
"fmt"
"os"
"path/filepath"
"syscall"

"github.com/rs/zerolog"
Expand Down Expand Up @@ -78,10 +79,19 @@ func New(m map[string]interface{}, stream events.Stream, log *zerolog.Logger) (s
switch o.MetadataBackend {
case "xattrs":
lu = lookup.New(metadata.NewXattrsBackend(o.Root, o.FileMetadataCache), um, o, &timemanager.Manager{})
case "messagepack":
lu = lookup.New(metadata.NewMessagePackBackend(o.Root, o.FileMetadataCache), um, o, &timemanager.Manager{})
case "hybrid":
lu = lookup.New(metadata.NewHybridBackend(1024, // start offloading grants after 1KB
func(n metadata.MetadataNode) string {
spaceRoot, _ := lu.IDCache.Get(context.Background(), n.GetSpaceID(), n.GetSpaceID())
if len(spaceRoot) == 0 {
return ""
}

return filepath.Join(spaceRoot, lookup.RevisionsDir, lookup.Pathify(n.GetID(), 4, 2)+".mpk")
},
o.FileMetadataCache), um, o, &timemanager.Manager{})
default:
return nil, fmt.Errorf("unknown metadata backend %s, only 'messagepack' or 'xattrs' (default) supported", o.MetadataBackend)
return nil, fmt.Errorf("unknown metadata backend %s, only 'xattrs' or 'hybrid' (default) supported", o.MetadataBackend)
}

trashbin, err := trashbin.New(o, lu, log)
Expand Down
Loading