fix: isTemporary() check for absolute paths #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `isTemporary()` check can be called with relative Paths (from ListFolder) and absolute path (from the filesystem Watcher). This should fix it to work in both case. While assuring that it does the most apropriate match for absolute paths. Closes: opencloud-eu/opencloud#1774
Author
|
Testing against opencloud in opencloud-eu/opencloud#1786 |
Author
|
This as passed now a couple of time in the OpenCloud ci (https://ci.opencloud.eu/repos/3/pipeline/340, https://ci.opencloud.eu/repos/3/pipeline/343 and https://ci.opencloud.eu/repos/3/pipeline/346) so at least it doesn't make things worse. All of the failed runs had at least the watchfs tests succeeding, which is what this PR is supposed to fix. |
butonic
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isTemporary()check can be called with relative Paths (from ListFolder) and absolute path (from the filesystem Watcher). This should fix it to work in both case. While assuring that it does the most apropriate match for absolute paths.Closes: opencloud-eu/opencloud#1774