fix: Use hash if filename too long during assimilate #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! I would prefer to either:
There have been reports in matrix about this: https://matrix.to/#/!MXIMfhTMMRFPuXSKJZ:matrix.org/$aIs4ORkOnX1RAh3IbVEj24U3ZC1lm7tco24R2omYsXw?via=chat.opencloud.eu&via=matrix.org&via=tchncs.de |
|
I agree that using nats for locking would be nice, but that's something for a future change. And when assimilating new files there is no file id to use for locking the metadata yet (like we normally do), so we have to use the path in some form. lgtm 👍 thanks for your contribution! |
aduffeck
approved these changes
Sep 23, 2025
github-project-automation
bot
moved this from In Progress
to Done
in OpenCloud Team Board
MahdiBaghbani
pushed a commit
to MahdiBaghbani/reva-opencloud
that referenced
this pull request
Oct 17, 2025
…ud-eu#352) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.39.0 to 0.41.0. - [Commits](golang/crypto@v0.39.0...v0.41.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.41.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During start OC will scan existing data however if a file's full path is too long the lock file cannot be created.
However we need to ensure that, for the same file the shortened filename is always the same, meanwhile reduce possible conflicts between files.
The solution is: For extra-long full paths, we can use first 240 byte of file full path's sha256.