log middleware: Implement Unwrap() method #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tusd http.Handler uses the SetReadDeadline and SetWriteDeadline methods of the net/http.NewResponseController API. For that to work it needs access to the underlying ResponseWriter that implement these calls. This is achieve by implementing the "Unwrap" method http.Handlers that implement wrappers for the underlying ResponseWriter. (See: https://tus.github.io/tusd/advanced-topics/usage-package/#i-am-getting-warnings-regarding-networkcontrolerrornetworktimeouterror-and-feature-not-supported-why) Fixes: opencloud-eu/opencloud#713
aduffeck
approved these changes
Jul 16, 2025
MahdiBaghbani
pushed a commit
to MahdiBaghbani/reva-opencloud
that referenced
this pull request
Oct 17, 2025
….golang.org/grpc/otelgrpc (opencloud-eu#285) Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.57.0 to 0.61.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.57.0...zpages/v0.61.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-version: 0.61.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tusd http.Handler uses the SetReadDeadline and SetWriteDeadline methods of the net/http.NewResponseController API. For that to work it needs access to the underlying ResponseWriter that implement these calls. This is achieve by implementing the "Unwrap" method http.Handlers that implement wrappers for the underlying ResponseWriter. (See:
https://tus.github.io/tusd/advanced-topics/usage-package/#i-am-getting-warnings-regarding-networkcontrolerrornetworktimeouterror-and-feature-not-supported-why)
Fixes: opencloud-eu/opencloud#713