Cache internal path and disabled flag #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InternalPath() is called multiple times during the lifetime of node objects. For space root nodes it's even called once per child when listing a dir, causing a huge amount of calls to the cache in case of the posix driver.
It is used a lot for spaceroot nodes and is relatively expensive.
butonic
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache internal path and the disabled flag on node object, sparing lots of requests to the ID cache (nats by default).
Caching the internal path also prevents nodes from changing their identity mid-flight, e.g. when assimilation alters the cache in the background.
Speeds up directory listings with posix fs by a factor of 2-3 on my machine.