Skip to content

Conversation

@aduffeck
Copy link

@aduffeck aduffeck commented Feb 5, 2025

No description provided.

@butonic
Copy link

butonic commented Feb 5, 2025

hm, versioning seems to work in general .. but revisions seem to emit wrong events
grafik

@aduffeck
Copy link
Author

aduffeck commented Feb 5, 2025

hm, versioning seems to work in general .. but revisions seem to emit wrong events

I think those are results of the .opencloud directly being assimilated and tracked. I was pondering whether we might want to ignore that directory or not but haven't really formed an opinion yet.

@butonic
Copy link

butonic commented Feb 6, 2025

the driver seems to still lock directories in the .OC-nodes directory:

root@eea6eeeb0288:/# ls -lah /var/lib/opencloud/storage/users/users/admin/
total 52K
drwxr-x--- 4 root root 4.0K Feb  6 16:02  .
drwxr-xr-x 3 root root 4.0K Feb  6 16:02  ..
drwx------ 3 root root 4.0K Feb  6 16:02  .OC-Nodes
-rw------- 1 root root    0 Feb  6 16:02  .OC-Nodes.mlock
drwx------ 2 root root  20K Feb  6 16:02 'Gregorz Rutkowski'
-rw-r--r-- 1 root root   12 Feb  6 16:02 'New file.txt'
root@eea6eeeb0288:/# ls -lah /var/lib/opencloud/storage/users/users/admin/.OC-Nodes
total 24K
drwx------ 3 root root 4.0K Feb  6 16:02 .
drwxr-x--- 4 root root 4.0K Feb  6 16:02 ..
drwx------ 3 root root 4.0K Feb  6 16:02 46
-rw------- 1 root root    0 Feb  6 16:02 46.mlock
root@eea6eeeb0288:/# ls -lah /var/lib/opencloud/storage/users/users/admin/.OC-Nodes
.OC-Nodes/       .OC-Nodes.mlock  
root@eea6eeeb0288:/# ls -lah /var/lib/opencloud/storage/users/users/admin/.OC-Nodes/46
46/       46.mlock  
root@eea6eeeb0288:/# ls -lah /var/lib/opencloud/storage/users/users/admin/.OC-Nodes/46/cf/54
54/       54.mlock  
root@eea6eeeb0288:/# ls -lah /var/lib/opencloud/storage/users/users/admin/.OC-Nodes/46/cf/54/2d/-3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16\:02\:
-3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:46.764867635Z  -3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:51.789233636Z  
-3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:50.023206478Z  -3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:53.093429545Z  
root@eea6eeeb0288:/# ls -lah /var/lib/opencloud/storage/users/users/admin/.OC-Nodes/46/cf/54/2d/                                                    
total 44K
-rw------- 1 root root    0 Feb  6 16:02 -3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:46.764867635Z
-rw------- 1 root root    3 Feb  6 16:02 -3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:50.023206478Z
-rw------- 1 root root    6 Feb  6 16:02 -3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:51.789233636Z
-rw------- 1 root root    9 Feb  6 16:02 -3d43-41b4-b437-14cd6683767f.REV.2025-02-06T16:02:53.093429545Z
drwx------ 2 root root 4.0K Feb  6 16:02 .
drwx------ 3 root root 4.0K Feb  6 16:02 ..

but that might be an issue for a subsequentt PR ... well ... or until we merge features again

@butonic
Copy link

butonic commented Feb 6, 2025

I cannot share a text file with alan ...

@aduffeck aduffeck marked this pull request as ready for review February 11, 2025 07:14

var tracer trace.Tracer

var _revisionsDir = ".OC-Nodes"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this all lower case here? .oc-nodes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for uppercasing it like this was to make it consistent with the fdo .Trash directory we're using I think. I personally don't have a strong opinion either way though and would change it to .oc-nodes, or do you object, @butonic ?

@aduffeck aduffeck merged commit 418bbbb into opencloud-eu:main Feb 13, 2025
@openclouders openclouders mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants