-
Notifications
You must be signed in to change notification settings - Fork 14
Implement revisions for the posix fs #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think those are results of the |
|
the driver seems to still lock directories in the .OC-nodes directory: but that might be an issue for a subsequentt PR ... well ... or until we merge features again |
|
I cannot share a text file with alan ... |
|
|
||
| var tracer trace.Tracer | ||
|
|
||
| var _revisionsDir = ".OC-Nodes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this all lower case here? .oc-nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for uppercasing it like this was to make it consistent with the fdo .Trash directory we're using I think. I personally don't have a strong opinion either way though and would change it to .oc-nodes, or do you object, @butonic ?

No description provided.