Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

Bumps github.com/nats-io/nats.go from 1.39.1 to 1.41.0.


updated-dependencies:

  • dependency-name: github.com/nats-io/nats.go dependency-version: 1.41.0 dependency-type: direct:production update-type: version-update:semver-minor ...

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

Bumps [github.com/nats-io/nats.go](https://github.com/nats-io/nats.go) from 1.39.1 to 1.41.0.
- [Release notes](https://github.com/nats-io/nats.go/releases)
- [Commits](nats-io/nats.go@v1.39.1...v1.41.0)

---
updated-dependencies:
- dependency-name: github.com/nats-io/nats.go
  dependency-version: 1.41.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@micbar
Copy link
Contributor

micbar commented Apr 17, 2025

We should not bump this on the stable branch.

@ScharfViktor
Copy link
Contributor Author

We should not bump this on the stable branch.

then we get error:

make clean
- activitylog: clean
go: inconsistent vendoring in /Users/v.scharf/Work/opencloud/opencloud:
        github.com/nats-io/nats.go@v1.41.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
        github.com/nats-io/nats.go@v1.39.1: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod

        To ignore the vendor directory, use -mod=readonly or -mod=mod.
        To sync the vendor directory, run:
                go mod vendor
make[1]: *** [clean] Error 1
make: *** [clean] Error 1

when I run go mod vendor -> I update to github.com/nats-io/nats.go v1.41.0

@micbar
Copy link
Contributor

micbar commented Apr 17, 2025

maybe this package has also been bumped in reva.

@ScharfViktor ScharfViktor requested a review from fschade April 17, 2025 08:02
@ScharfViktor
Copy link
Contributor Author

maybe this package has also been bumped in reva.

no, they're not up to date there.
https://github.com/opencloud-eu/reva/blob/stable-2.29/go.mod#L59-L60

should I do it? and create new reva release and new bump?

@fschade fschade merged commit b67ce7c into stable-2.0 Apr 17, 2025
53 of 54 checks passed
@fschade fschade deleted the port#567 branch April 17, 2025 09:29
@openclouders openclouders mentioned this pull request Apr 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants