-
Notifications
You must be signed in to change notification settings - Fork 158
Feat: install.sh now honors OC_BASE_DIR and OC_HOST #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dragotin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot :-)
|
@dragotin Added another variable OC_HOST, please re-review. Background: (We don't have a config.json in the config folder, but that is |
Co-authored-by: Klaas Freitag <kraft@freisturz.de>
|
The check fails with Is there anything I can do to push this forward? |
I don't think that we need run CI here. Approve -> merge |

Description
The quick install.sh has hardcoded paths.
This feature adds an option to set (both!) config and data to some specified parent directory as well as the hostname of the server.
Motivation and Context
Simplifies testing with different back end storages.
Locally and on remote servers
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: