Skip to content

Conversation

@jnweiger
Copy link
Contributor

@jnweiger jnweiger commented Apr 5, 2025

Description

The quick install.sh has hardcoded paths.
This feature adds an option to set (both!) config and data to some specified parent directory as well as the hostname of the server.

Motivation and Context

Simplifies testing with different back end storages.
Locally and on remote servers

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :-)

@jnweiger jnweiger requested a review from dragotin April 6, 2025 12:29
@jnweiger jnweiger changed the title Feat: install.sh now honors OC_BASE_DIR Feat: install.sh now honors OC_BASE_DIR and OC_HOST Apr 6, 2025
@jnweiger
Copy link
Contributor Author

jnweiger commented Apr 6, 2025

@dragotin Added another variable OC_HOST, please re-review.

Background:
The addition of OC_HOST was actually motivated by a misleading error message in web.
When trying to access from remote, redirects were wrongly generated for e.g.
https://localhost:9200/themes/opencloud/theme.json but the error message shown in the web UI is a misleading
grafik

(We don't have a config.json in the config folder, but that is
a) harmless
b) and not the point. The thing that is actually missing is theme.json)

Co-authored-by: Klaas Freitag <kraft@freisturz.de>
@jnweiger
Copy link
Contributor Author

jnweiger commented Apr 9, 2025

The check fails with

Run mheap/github-action-required-labels@v5
Error: Resource not accessible by integration

Is there anything I can do to push this forward?

@ScharfViktor
Copy link
Contributor

Is there anything I can do to push this forward?

I don't think that we need run CI here. Approve -> merge

@ScharfViktor ScharfViktor enabled auto-merge April 15, 2025 08:26
@ScharfViktor ScharfViktor merged commit 945c04d into opencloud-eu:main Apr 15, 2025
1 of 6 checks passed
@openclouders openclouders mentioned this pull request Apr 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants