[full-ci] fix(collaboration): hide SaveAs and ExportAs buttons in web office #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
changed the title
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
2 times, most recently
from
5718709 to
f34c932
Compare
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
from
f34c932 to
19ea614
Compare
micbar
previously requested changes
Mar 25, 2025
| fileinfo.KeyLicenseCheckForEditIsEnabled: f.cfg.App.LicenseCheckEnable, | ||
|
|
||
| // forbid PutRelativeFile, hide "Save As" and "Export As" buttons | ||
| fileinfo.KeyUserCanNotWriteRelative: true, |
Contributor
There was a problem hiding this comment.
This needs to only be disabled for collabora.
Contributor
Author
There was a problem hiding this comment.
Done. Please check again :-)
2 tasks
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
from
dce2e5c to
5c8f5ab
Compare
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
from
5c8f5ab to
43a5e24
Compare
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
from
0b47e80 to
63cd3c6
Compare
Contributor
|
tested. no buttons
approve from testing side 👍 |
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
from
27a64bd to
a6774ab
Compare
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
from
a6774ab to
27e3646
Compare
Contributor
|
Ci has 2 fails:
and e2e multiple services. |
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
2 times, most recently
from
e95535c to
80cdfb0
Compare
kulmann
force-pushed
the
weboffice-disable-save-as-button
branch
from
80cdfb0 to
700ffbc
Compare
JammingBen
approved these changes
Mar 26, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set
UserCanNotWriteRelativetotrueso thatSave AsandExport Asbuttons get hidden in the UI.See https://sdk.collaboraonline.com/docs/advanced_integration.html?highlight=usercannotwriterelative#usercannotwriterelative for more info.
Related Issue
Motivation and Context
Don't offer broken functionality in the UI.
How Has This Been Tested?
Manually with custom built docker image.
Types of changes