Switch to jsoncs3 backend for app tokens and enable service by default #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
changed the title
Contributor
Author
|
For making delete app token request work in the UI we need this reva change: opencloud-eu/reva#119 |
Contributor
Author
|
@kulmann As discussed, this now also allows setting the label on the app password. |
aduffeck
approved these changes
Mar 20, 2025
Co-Authored-By: André Duffeck <a.duffeck@opencloud.eu>
Instead of using the same hardcoded label for all app tokens, allow to specify one on the API. When an app token is generate via the impersonation feature we add the string ` (Impersonation)` to the label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the default config of the app-auth service to use the jsoncs3 backend. We generate password base on the diceware algorithm by default using the default length of 6 words.
This also enables the app token service by default. ❗