Skip to content

More graceful shutdown fixes#2690

Merged
rhafer merged 10 commits into
opencloud-eu:mainfrom
rhafer:issue/2282
Apr 28, 2026
Merged

More graceful shutdown fixes#2690
rhafer merged 10 commits into
opencloud-eu:mainfrom
rhafer:issue/2282

Conversation

@rhafer

@rhafer rhafer commented Apr 28, 2026

Copy link
Copy Markdown
Member

This reverts #2631 and contains an alternative fix for graceful shutdown via Suture by avoiding the Supervisor to be stopped early.

rhafer added 8 commits April 28, 2026 12:22
This reverts commit 900ecf7.
Previously the Supervisor was shutdonw as soon as the main context was
canceled. Which cause the managed services to fail during shutdown (in
"trapShutdownCtx()") as the Supervisor was gone already.

We now pass a separate Context to Supervisor.ServeBackground() to avoid
this.

Fixes: opencloud-eu#2282
@rhafer rhafer requested review from butonic and dragonchaser April 28, 2026 10:42
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

@butonic butonic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@sonarqubecloud

sonarqubecloud Bot commented Apr 28, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@rhafer rhafer merged commit 9135eab into opencloud-eu:main Apr 28, 2026
60 of 61 checks passed
@openclouders openclouders mentioned this pull request Apr 28, 2026
1 task
sdwilsh pushed a commit to sdwilsh/ansible-playbooks that referenced this pull request May 16, 2026
##### [\`6.2.0\`](https://github.com/opencloud-eu/opencloud/blob/HEAD/CHANGELOG.md#620---2026-05-11)

##### ❤️ Thanks to all contributors! ❤️

[@JammingBen](https://github.com/JammingBen), [@ScharfViktor](https://github.com/ScharfViktor), [@Sweeistaken](https://github.com/Sweeistaken), [@aduffeck](https://github.com/aduffeck), [@dragonchaser](https://github.com/dragonchaser), [@dschmidt](https://github.com/dschmidt), [@fschade](https://github.com/fschade), [@pedropintosilva](https://github.com/pedropintosilva), [@rhafer](https://github.com/rhafer), [@schweigisito](https://github.com/schweigisito)

##### 📈 Enhancement

- feat: enable EnableRemoteLinkPicker WOPI flag for Collabora Online \[[#2663](opencloud-eu/opencloud#2663)]
- feat(kql): support dotted keys in property restrictions \[[#2632](opencloud-eu/opencloud#2632)]

##### 🐛 Bug Fixes

- Set new defaults for caches and stores \[[#2702](opencloud-eu/opencloud#2702)]
- fix: remove typo in error message \[[#2701](opencloud-eu/opencloud#2701)]
- fix(search): preserve value case for non-lowercased bleve fields \[[#2633](opencloud-eu/opencloud#2633)]
- More graceful shutdown fixes \[[#2690](opencloud-eu/opencloud#2690)]
- Hotfix for [#2282](opencloud-eu/opencloud#2282) \[[#2631](opencloud-eu/opencloud#2631)]
- fix(search): read --force-rescan flag with its registered name \[[#2639](opencloud-eu/opencloud#2639)]
- fix(search): parse tika xmpDM:duration as a float \[[#2638](opencloud-eu/opencloud#2638)]

##### ✅ Tests

- \[api-tests] delete PROPATCH favorite tests \[[#2689](opencloud-eu/opencloud#2689)]

##### 📚 Documentation

- enhancement: increase display size of graph flow diagram \[[#2620](opencloud-eu/opencloud#2620)]

##### 📦️ Dependencies

- build(deps): bump go.opentelemetry.io/contrib/zpages from 0.67.0 to 0.68.0 \[[#2666](opencloud-eu/opencloud#2666)]
- build(deps): bump [@types/node](https://github.com/types/node) from 22.19.17 to 25.6.0 in /services/idp \[[#2687](opencloud-eu/opencloud#2687)]
- build(deps): bump go.opentelemetry.io/otel/exporters/stdout/stdouttrace from 1.42.0 to 1.43.0 \[[#2601](opencloud-eu/opencloud#2601)]
- build(deps): bump github.com/davidbyttow/govips/v2 from 2.17.0 to 2.18.0 \[[#2656](opencloud-eu/opencloud#2656)]
- build(deps): bump i18next from 25.10.10 to 26.0.4 in /services/idp \[[#2609](opencloud-eu/opencloud#2609)]
- build(deps): bump github.com/testcontainers/testcontainers-go/modules/opensearch from 0.41.0 to 0.42.0 \[[#2645](opencloud-eu/opencloud#2645)]
- build(deps): bump github.com/open-policy-agent/opa from 1.15.1 to 1.15.2 \[[#2602](opencloud-eu/opencloud#2602)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants