fix: Show username in unprivileged search results #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`onPremisesSamAccountName` is a mandatory attribute according to the spec. There's no harm in returning it in the search results also for unprivileged users. Fixes: opencloud-eu#144
Contributor
|
the existing tests expect an empty string, but I think we can now expect diff --git a/tests/acceptance/features/apiTenancy/mutltiTenancy.feature b/tests/acceptance/features/apiTenancy/mutltiTenancy.feature
index e989a0789b9..21a796c1a4e 100644
--- a/tests/acceptance/features/apiTenancy/mutltiTenancy.feature
+++ b/tests/acceptance/features/apiTenancy/mutltiTenancy.feature
@@ -45,7 +45,7 @@ Feature: Multi-tenancy
"pattern": "^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$"
},
"onPremisesSamAccountName": {
- "const": ""
+ "const": "alice"
},
"userType": {
"const": "Member" |
Contributor
yes, I'll adapt tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onPremisesSamAccountNameis a mandatory attribute according to the spec. There's no harm in returning it in the search results also for unprivileged users.Fixes: #144