Skip to content

Conversation

@dragonchaser
Copy link
Contributor

@dragonchaser dragonchaser commented Dec 2, 2025

We have replaced urfave/cli by spf13/cobra, because urfave had issues with race conditions and we could not fix them.

Hints for reviewers:

TODO:

err := corbraCommandVariable.MarkFlagRequired("<flagname>")
if err != nil {
	fmt.Println(err)
}

@dragonchaser dragonchaser added the Type:Maintenance E.g. technical debt, packaging, etc. label Dec 2, 2025
@dragonchaser dragonchaser force-pushed the kill_urfave branch 3 times, most recently from b1caa52 to 65598d3 Compare December 4, 2025 09:26
@dragonchaser
Copy link
Contributor Author

dragonchaser commented Dec 5, 2025

There is still an issue with the output of the subcommand usage from opencloud/bin/opencloud all commands are there, can be output with opencloud/bin/opencloud sse --help but running opencloud/bin/opencloud sse no usage is displayed.

Update: dde1a43 fixes the issue

restart, _ := cmd.Flags().GetBool("restart")
var ev events.Unmarshaller
switch {
case c.Bool("retrigger"):
Copy link
Contributor

@butonic butonic Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this ever work? the flag was registered as restart

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t 👀

Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
butonic and others added 17 commits December 15, 2025 16:40
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@fschade fschade marked this pull request as ready for review December 15, 2025 15:44
@fschade fschade requested review from micbar and rhafer December 16, 2025 07:45
@butonic butonic changed the title [WIP] migrate from urfave/cli to spf13/cobra migrate from urfave/cli to spf13/cobra Dec 16, 2025
@fschade fschade merged commit db3178c into opencloud-eu:main Dec 16, 2025
61 checks passed
@openclouders openclouders mentioned this pull request Dec 16, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Enhancement Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants