Skip to content

Conversation

@flimmy
Copy link
Contributor

@flimmy flimmy commented Nov 20, 2025

Description

add a simple check to prevent the latest tag to be set on pre-release tag events

Motivation and Context

the latest tag should not be set for pre-releases

How Has This Been Tested?

It only has been tested using static values in a separate repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds logic to prevent the "latest" tag from being applied to Docker images when building from pre-release tags. The implementation checks if a tag contains a hyphen (indicating pre-release suffixes like alpha, beta, or rc), and if so, uses the full tag name instead of allowing the build plugin to auto-tag with "latest".

  • Introduces tag parsing logic to detect pre-release versions by checking for hyphenated suffixes
  • Modifies the Docker release configuration to conditionally set tags based on whether the release is a pre-release
  • Replaces hardcoded "daily" tag logic with a variable that adapts to tag type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@flimmy flimmy added the Type:DevOps Related to CI/CD label Nov 20, 2025
@flimmy flimmy force-pushed the fix_rc_latest_overwrite branch from 549d0ad to e0e9d36 Compare November 20, 2025 10:24
@flimmy flimmy force-pushed the fix_rc_latest_overwrite branch from e0e9d36 to 205ffbb Compare November 20, 2025 10:28
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got 3 YESses 😄

@flimmy flimmy merged commit 90e4127 into main Nov 20, 2025
58 checks passed
@flimmy flimmy deleted the fix_rc_latest_overwrite branch November 20, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants