Skip to content

Sync share before action #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhafer merged 2 commits into from
Nov 6, 2025
Merged

Sync share before action #1795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
369c955
Sync share before action
ScharfViktor Nov 6, 2025
f715f5a
lint fix
ScharfViktor Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/acceptance/expected-failures-API-on-decomposed-storage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ _ocdav: api compatibility, return correct status code_
- [coreApiWebdavUploadTUS/uploadToShare.feature:256](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L256)
- [coreApiWebdavUploadTUS/uploadToShare.feature:279](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L279)
- [coreApiWebdavUploadTUS/uploadToShare.feature:280](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L280)
- [coreApiWebdavUploadTUS/uploadToShare.feature:375](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L375)
- [coreApiWebdavUploadTUS/uploadToShare.feature:376](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L376)
- [coreApiWebdavUploadTUS/uploadToShare.feature:377](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L377)

#### [Renaming resource to banned name is allowed in spaces webdav](https://github.com/owncloud/ocis/issues/3099)

Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/expected-failures-API-on-posix-storage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ _ocdav: api compatibility, return correct status code_
- [coreApiWebdavUploadTUS/uploadToShare.feature:256](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L256)
- [coreApiWebdavUploadTUS/uploadToShare.feature:279](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L279)
- [coreApiWebdavUploadTUS/uploadToShare.feature:280](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L280)
- [coreApiWebdavUploadTUS/uploadToShare.feature:375](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L375)
- [coreApiWebdavUploadTUS/uploadToShare.feature:376](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L376)
- [coreApiWebdavUploadTUS/uploadToShare.feature:377](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L377)

#### [Renaming resource to banned name is allowed in spaces webdav](https://github.com/owncloud/ocis/issues/3099)

Expand Down
30 changes: 20 additions & 10 deletions tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Feature: sharing
| sharee | grp1 |
| shareType | group |
| permissionsRole | File Editor |
And user "Brian" has a share "textfile0.txt" synced
And user "Brian" has moved file "/Shares/textfile0.txt" to "/Shares/anotherName.txt"
When user "Alice" deletes the last share using the sharing API
Then the OCS status code should be "<ocs-status-code>"
Expand Down Expand Up @@ -89,6 +90,7 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | Editor |
And user "Brian" has a share "shared" synced
When user "Brian" deletes file "/Shares/shared/shared_file.txt" using the WebDAV API
Then the HTTP status code should be "204"
And as "Brian" file "/Shares/shared/shared_file.txt" should not exist
Expand All @@ -114,6 +116,7 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | Editor |
And user "Brian" has a share "shared" synced
When user "Brian" deletes folder "/Shares/shared/sub" using the WebDAV API
Then the HTTP status code should be "204"
And as "Brian" folder "/Shares/shared/sub" should not exist
Expand Down Expand Up @@ -165,6 +168,7 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | Viewer |
And user "Brian" has a share "shared" synced
When user "Brian" deletes file "/Shares/shared/shared_file.txt" using the WebDAV API
Then the HTTP status code should be "403"
And as "Alice" file "/shared/shared_file.txt" should exist
Expand All @@ -187,6 +191,7 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | Uploader |
And user "Brian" has a share "shared" synced
When user "Brian" deletes file "/Shares/shared/shared_file.txt" using the WebDAV API
Then the HTTP status code should be "403"
And as "Alice" file "/shared/shared_file.txt" should exist
Expand All @@ -208,6 +213,7 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | Uploader |
And user "Brian" has a share "shared" synced
And user "Brian" has uploaded file "filesForUpload/textfile.txt" to "/Shares/shared/textfile.txt"
When user "Brian" deletes file "/Shares/shared/textfile.txt" using the WebDAV API
Then the HTTP status code should be "403"
Expand Down Expand Up @@ -237,18 +243,19 @@ Feature: sharing
| sharee | grp1 |
| shareType | group |
| permissionsRole | <permission-role> |
And user "Brian" has a share "<sync-entry>" synced
When user "Brian" deletes the last share of user "Alice" using the sharing API
Then the OCS status code should be "996"
And the HTTP status code should be "<http-status-code>"
And as "Alice" entry "<entry-to-share>" should exist
And as "Brian" entry "<received-entry>" should exist
And as "Carol" entry "<received-entry>" should exist
Examples:
| entry-to-share | permission-role | ocs-api-version | http-status-code | received-entry |
| /shared/shared_file.txt | File Editor | 1 | 200 | /Shares/shared_file.txt |
| /shared/shared_file.txt | File Editor | 2 | 500 | /Shares/shared_file.txt |
| /shared | Editor | 1 | 200 | /Shares/shared |
| /shared | Editor | 2 | 500 | /Shares/shared |
| entry-to-share | permission-role | ocs-api-version | http-status-code | received-entry | sync-entry |
| /shared/shared_file.txt | File Editor | 1 | 200 | /Shares/shared_file.txt | shared_file.txt |
| /shared/shared_file.txt | File Editor | 2 | 500 | /Shares/shared_file.txt | shared_file.txt |
| /shared | Editor | 1 | 200 | /Shares/shared | shared |
| /shared | Editor | 2 | 500 | /Shares/shared | shared |


Scenario Outline: individual share recipient tries to delete the share
Expand All @@ -262,17 +269,18 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | <permission-role> |
And user "Brian" has a share "<sync-entry>" synced
When user "Brian" deletes the last share of user "Alice" using the sharing API
Then the OCS status code should be "996"
And the HTTP status code should be "<http-status-code>"
And as "Alice" entry "<entry-to-share>" should exist
And as "Brian" entry "<received-entry>" should exist
Examples:
| entry-to-share | permission-role | ocs-api-version | http-status-code | received-entry |
| /shared/shared_file.txt | File Editor | 1 | 200 | /Shares/shared_file.txt |
| /shared/shared_file.txt | File Editor | 2 | 500 | /Shares/shared_file.txt |
| /shared | Editor | 1 | 200 | /Shares/shared |
| /shared | Editor | 2 | 500 | /Shares/shared |
| entry-to-share | permission-role | ocs-api-version | http-status-code | received-entry | sync-entry |
| /shared/shared_file.txt | File Editor | 1 | 200 | /Shares/shared_file.txt | shared_file.txt |
| /shared/shared_file.txt | File Editor | 2 | 500 | /Shares/shared_file.txt | shared_file.txt |
| /shared | Editor | 1 | 200 | /Shares/shared | shared |
| /shared | Editor | 2 | 500 | /Shares/shared | shared |

@issue-720
Scenario Outline: request PROPFIND after sharer deletes the collaborator
Expand All @@ -284,6 +292,7 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | File Editor |
And user "Brian" has a share "textfile0.txt" synced
When user "Alice" deletes the last share using the sharing API
Then the OCS status code should be "<ocs-status-code>"
And the HTTP status code should be "200"
Expand All @@ -304,6 +313,7 @@ Feature: sharing
| sharee | Brian |
| shareType | user |
| permissionsRole | File Editor |
And user "Brian" has a share "textfile0.txt" synced
When user "Brian" tries to delete the last share of user "Alice" using the sharing API
Then the HTTP status code should be "<http-status-code>"
And the OCS status code should be "996"
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ Feature: upload file to shared folder
And user "Alice" sends a chunk to the last created TUS Location with offset "5" and data "56789" with checksum "MD5 099ebea48ea9666a7da2177267983138" using the TUS protocol on the WebDAV API
And user "Alice" shares file "textFile.txt" with user "Brian" using the sharing API
Then the HTTP status code should be "200"
And user "Brian" has a share "textFile.txt" synced
And the content of file "/Shares/textFile.txt" for user "Brian" should be "0123456789"
Examples:
| dav-path-version |
Expand Down