Skip to content

fix: set global signing secret fallback correctly #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhafer merged 2 commits into from
Nov 5, 2025
Merged

fix: set global signing secret fallback correctly #1781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20a630c
fix: set global signing secret fallback correctly
rhafer Nov 5, 2025
00bc1cb
fix typo
rhafer Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions pkg/config/parser/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,13 @@ func EnsureCommons(cfg *config.Config) {
cfg.Commons.TransferSecret = cfg.TransferSecret
}

// copy url signing secret to the commons part if set
if cfg.URLSigningSecret != "" {
cfg.Commons.URLSigningSecret = cfg.URLSigningSecret
} else {
// fall back to transfer secret for url signing secret to avoid
// issues when upgradin from an older release
cfg.Commons.URLSigningSecret = cfg.TransferSecret
// make sure url signing secret is set and copy it to the commons part
// fall back to transfer secret for url signing secret to avoid
// issues when upgrading from an older release
if cfg.URLSigningSecret == "" {
cfg.URLSigningSecret = cfg.TransferSecret
}
cfg.Commons.URLSigningSecret = cfg.URLSigningSecret

// copy metadata user id to the commons part if set
if cfg.SystemUserID != "" {
Expand Down