Skip to content

Conversation

@schweigisito
Copy link
Contributor

@schweigisito schweigisito commented Oct 24, 2025

Description

This PR fixes #1698, an issue that notification emails don't contain Message-Id headers.

Related Issue

Motivation and Context

This adds a quite important mail header which is needed to achieve

  • tracking message threads and conversations
  • detecting duplicate messages
  • creating proper reply chains (along with In-Reply-To and References headers)
  • debugging mail delivery issues
  • proper spam detection systems

How Has This Been Tested?

Dev Docker image has been built and deployed using opencloud-eu/opencloud-compose

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

@schweigisito schweigisito self-assigned this Oct 24, 2025
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Oct 24, 2025
@schweigisito schweigisito moved this from Qualification to In Progress in OpenCloud Team Board Oct 24, 2025
@schweigisito schweigisito changed the title fix: fix #1698 - Notification email doesn't contain Message-ID header fix: fix #1698 - Notification email doesn't contain Message-Id header Oct 24, 2025
@schweigisito schweigisito requested a review from rhafer October 24, 2025 15:38

import (
"context"
"crypto/rand"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really sure if we need crypto save random numbers for the message ids. I guess a properly seeded pseudo random numbers from math/crypto could also be enough for that purpose.
But I guess it's fine this way as well.

@AlexAndBear AlexAndBear force-pushed the schweigisito/issue1698 branch from 5d39f1b to e7a4cba Compare October 27, 2025 17:56
@schweigisito schweigisito merged commit 10e7776 into main Oct 27, 2025
58 checks passed
@schweigisito schweigisito deleted the schweigisito/issue1698 branch October 27, 2025 19:59
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenCloud Team Board Oct 27, 2025
@openclouders openclouders mentioned this pull request Oct 27, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Notification email doesn't contain Message-Id header

3 participants