graph: Make the nats dependency optional, fix readyness check #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For running the Graph Education API we want to keep it possible to run the service standalone. With an LDAP server as the only external dependency.
The readyz endpoint contained unconditional checks for the LDAP and nats endpoints. Depending on configuration neihter LDAP nor NATS might be required.
rhafer
changed the title
Contributor
Author
|
I am force merging this now despite the failing ci run. The previous run was green apart from the unit test, which have succeeded now. All the test that are failing now succeeded in the previous run. The current failures (e.g. https://ci.opencloud.eu/repos/3/pipeline/660/232) are in no way related to the code changes. |
Contributor
|
The daily image has been built. I tested it. It works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to run the graph service without NATs. Standalone for the Provisioning API.
Also the LDAP dependency is optional in some cases (GRAPH_IDENTITY_BACKEND=cs3)