Skip to content

Conversation

@dragonchaser
Copy link
Contributor

@dragonchaser dragonchaser commented Oct 6, 2025

We have added the ability to merge custom CSP rules configuration with the provided ones through PROXY_CSP_CONFIG_FILE_LOCATION (and its yaml equivalent csp_config_file_location) and the ability to completely override the CSP rules configuration through PROXY_CSP_CONFIG_FILE_OVERRIDE_LOCATION (and its yaml equivalent csp_config_file_override_location)

refs #1475

@butonic
Copy link
Contributor

butonic commented Nov 14, 2025

nice! hm ... I'm nut sure this produces what we expect, when an admin has currently provided a csp rule file where he dropped eg the rules to github. would we not then merge them back because they are in our default? ... I guess that is fine, because he can now overrule them ... but we need to document this propertly ... as it might cause unwanted security sideeffects.

I am aware of #1475 (comment) ... but why don't we introduce a PROXY_CSP_CONFIG_CUSTOMIZATIONS_FILE that allows adding additional rules. If someone really wants to get rid of the rules we provide he can point PROXY_CSP_CONFIG_FILE_LOCATION to an empty file and use his PROXY_CSP_CONFIG_CUSTOMIZATIONS_FILE. Of course he will then have to deal with updates himself.

I find that clearer than an PROXY_CSP_CONFIG_FILE_OVERRIDE_LOCATION.

hm ... I'm not against this ... I am just worried about admins screaming "security incident!!!"

@dragonchaser dragonchaser marked this pull request as ready for review November 14, 2025 13:20
@kulmann
Copy link
Contributor

kulmann commented Nov 18, 2025

I find that clearer than an PROXY_CSP_CONFIG_FILE_OVERRIDE_LOCATION.

hm ... I'm not against this ... I am just worried about admins screaming "security incident!!!"

... but it would still leave the update check broken for an unknown number of existing instances. Which is the point of my bug report and the main reason for this PR.

But I agree that we need clear documentation about all of this.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works like a charm now! Tested both the augmentation and the override successfully. Thank you so much for fixing this!

Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
@dragonchaser dragonchaser merged commit 95b19c7 into opencloud-eu:main Nov 19, 2025
58 checks passed
@dragonchaser dragonchaser deleted the merge-csp-configs branch November 19, 2025 13:20
@openclouders openclouders mentioned this pull request Nov 18, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants