-
Notifications
You must be signed in to change notification settings - Fork 158
load two yaml configs #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load two yaml configs #1617
Conversation
713b276 to
716bb96
Compare
ce1f4af to
7019bc4
Compare
7019bc4 to
dc0237b
Compare
dc0237b to
aca6be4
Compare
0698d49 to
b81551d
Compare
|
nice! hm ... I'm nut sure this produces what we expect, when an admin has currently provided a csp rule file where he dropped eg the rules to github. would we not then merge them back because they are in our default? ... I guess that is fine, because he can now overrule them ... but we need to document this propertly ... as it might cause unwanted security sideeffects. I am aware of #1475 (comment) ... but why don't we introduce a PROXY_CSP_CONFIG_CUSTOMIZATIONS_FILE that allows adding additional rules. If someone really wants to get rid of the rules we provide he can point PROXY_CSP_CONFIG_FILE_LOCATION to an empty file and use his PROXY_CSP_CONFIG_CUSTOMIZATIONS_FILE. Of course he will then have to deal with updates himself. I find that clearer than an PROXY_CSP_CONFIG_FILE_OVERRIDE_LOCATION. hm ... I'm not against this ... I am just worried about admins screaming "security incident!!!" |
... but it would still leave the update check broken for an unknown number of existing instances. Which is the point of my bug report and the main reason for this PR. But I agree that we need clear documentation about all of this. |
bd9ae61 to
2241efc
Compare
be2d4ef to
7467cee
Compare
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works like a charm now! Tested both the augmentation and the override successfully. Thank you so much for fixing this!
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
Signed-off-by: Christian Richter <c.richter@opencloud.eu>
7467cee to
97ee9b3
Compare
We have added the ability to merge custom CSP rules configuration with the provided ones through
PROXY_CSP_CONFIG_FILE_LOCATION(and its yaml equivalentcsp_config_file_location) and the ability to completely override the CSP rules configuration throughPROXY_CSP_CONFIG_FILE_OVERRIDE_LOCATION(and its yaml equivalentcsp_config_file_override_location)refs #1475