Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Sep 26, 2025

  • Added getCreatedSpace() method to fetch spaces from locally saved cache
  • Updated getSpaceByName() to:
    • Check local cache first
    • Fetch personal space via Graph API if not in cache
    • Fall back to listing all available spaces via Graph API for users/admins
  • Reduced unnecessary API calls and improved performance
  • Added inline comments explaining the logic

@ScharfViktor ScharfViktor force-pushed the get-space-from-cache-or-graph branch from 95316e6 to 570b23d Compare September 29, 2025 14:21
@ScharfViktor ScharfViktor marked this pull request as ready for review September 29, 2025 16:06
@ScharfViktor ScharfViktor force-pushed the get-space-from-cache-or-graph branch from 570b23d to c299c14 Compare September 29, 2025 16:06
@ScharfViktor ScharfViktor force-pushed the get-space-from-cache-or-graph branch from c299c14 to 00baf45 Compare September 29, 2025 18:35
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a minor error in one of the comments.
Also (optionally) there might be "easier" endpoints for getting the personal space of a specific user.

@ScharfViktor ScharfViktor requested a review from rhafer September 30, 2025 10:30
@ScharfViktor ScharfViktor merged commit 2524678 into main Sep 30, 2025
99 checks passed
@ScharfViktor ScharfViktor deleted the get-space-from-cache-or-graph branch September 30, 2025 11:08
@openclouders openclouders mentioned this pull request Sep 30, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants