[full-ci] getting personal space by userId instead of userName #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScharfViktor
changed the title
rhafer
approved these changes
Sep 25, 2025
Contributor
rhafer
left a comment
rhafer
left a comment
There was a problem hiding this comment.
I am by no means a PHP coder, so I didn't really review the code style an stuff. But the way you get the personal space now looks fine to me.
individual-it
requested changes
Sep 26, 2025
individual-it
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
getUserIdByUserName()→ replaced withgetAttributeOfCreatedUser($user, 'id'), which reduces the number of requests to/graph/v1.0/users.Added
getPersonalSpace(), which retrieves a space byuserId(instead of by name) via/graph/v1.0/users/{userId}?%24select=&%24expand=drive, ensuring the correct personal space is found even in case of duplicates (e.g., soft-deleted users).