Tracing improvements #1436
Merged
Tracing improvements #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just add the request id as an attribute to the span created by the 'otelhttp' middleware.
fschade
approved these changes
Sep 2, 2025
Contributor
fschade
left a comment
fschade
left a comment
There was a problem hiding this comment.
optional
fmt.Sprintf("%s %v", req.Method, req.URL.Path)could be
fmt.Sprintf("%s %s", req.Method, req.URL.Path)
rhafer
force-pushed
the
tracing-improvements
branch
from
496ad82 to
00c8029
Compare
Each middleware adds a new span with a useful name now.
The graph service uses the `otelchi` middleware now to get at least some basic tracing enabled.
rhafer
force-pushed
the
tracing-improvements
branch
from
00c8029 to
ab6c39e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some smaller improvement for tracing
I am still somewhat unhappy with how the span for the middlewares are created. Each middleware's span is the child span for the middleware that is before it in the chain. I'd prefer if they were just childs of the top-level span created by the otel framework. I might be missing something obvious, but it seems really clumsy to create the spans that way because of the way how they are passed via context.