proxy(sign_url_auth): Allow to verify server signed URLs #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2025
Contributor
Contributor
Author
|
@AlexAndBear should work now
|
Contributor
|
TYSM! |
rhafer
force-pushed
the
issue/1104
branch
3 times, most recently
from
f440e79 to
e1de34d
Compare
The signedurl middleware is already adding the user to the context.
With the ocdav service being able to provided signed download URLs we need the proxy to be able to verify the signatures. This should also be a first step towards phasing out the weird ocs based client side signed urls. Related Tickets: opencloud-eu#1104
aduffeck
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ocdav service being able to provided signed download URLs we need the proxy to be able to verify the signatures.
This should also be a first step towards phasing out the weird ocs based client side signed urls.
Related Tickets: #1104
This is still a bit of a PoC, but should be good enough for providing allowing some traction on: opencloud-eu/web#704
Unfortunately in its current form it is a breaking change (a new configuration key is required) and would require a major version bump again. I'd be interested in suggestions about how we can make this non-breaking in a simple way.
To use this the new config variable
OC_URL_SIGNING_SHARED_SECRETneeds to be set. (Just use some randon string content)