[Collabora] Pass Health Check

[micbar]

Description

User Stories

• As a collabora user, i do not want to be bothered by technical errors to not lose trust in the software

Value

Increase trust in the software

Acceptance Criteria

• Addidtional WOPI Fileinfo properties are implemented for collabora
  • https://sdk.collaboraonline.com/docs/advanced_integration.html#isadminuser
  • https://sdk.collaboraonline.com/docs/advanced_integration.html#isanonymoususer
• PostMessage API is initialized

Definition of ready

• Everybody needs to understand the value written in the user story
• Acceptance criteria have to be defined
• All dependencies of the user story need to be identified
• Feature should be seen from an end user perspective
• Story has to be estimated
• Story points need to be less than 20

Definition of done

• Functional requirements
  • Functionality described in the user story works
  • Acceptance criteria are fulfilled
• Quality
  • Code review happened
  • CI is green (that includes new and existing automated tests)
  • Critical code received unit tests by the developer
• Non-functional requirements
  • No sonar cloud issues
• Configuration changes
  • The next branch of the OpenCloud charts is compatible

[kulmann]

The PostMessageAPI is properly initialized by now. ✅

[tbsbdr]

Users should never see this kind of messages as long as the application works for th euser. from my side it would be okay to hardcode the isAdmin value 🙈

[AlexAndBear]

Hardcoding isAdmin setting would be a very bad idea because of https://github.com/opencloud-eu/internal/issues/209#issuecomment-3436071875

[micbar]

Let us create a new permission for that.

I think that needs to be done before the code freeze.

[rhafer]

Just setting the IsAdminUser property to false unconditionally might also be a solution for now. The healthcheck is just complaining about it not being set at all.

I think setting the IsAdminUser property based on some permission will only make sense once get into implementing the user/shared settings stuff. I don't think that that will happen before the release. As it requires additional endpoints to be implemented in the collaboration service.

[micbar]

Ok. My understanding was: we set the flag and collabora does the rest? As long as we do not implement it in our settings, it can be accessed via collabora when editing a file, but only if the flag is set.

@JammingBen ?

[rhafer]

Maybe we're talking about different things. But the settings stuff is a bit more involved if I understand the docs correctly: https://sdk.collaboraonline.com/docs/advanced_integration.html#setup-settings-iframe

The only thing that happens automatically based on the IsAdminUser flag is that the contents of the settings iframe change based so that for the admin users also the system settings are include.

AFAICT the IsAdminUser flag also seems to hide a couple of elements from the UI. E.g. the Server Audit will only be visible if IsAdminUser is set to true (I just tried that). 😢 But still, depending on how messy it gets to add that additional permission and actually evaluate it in the collaboration service I think setting IsAdminUser to false unconditionally would be a valid option for the coming release.

[JammingBen]

Ok. My understanding was: we set the flag and collabora does the rest? As long as we do not implement it in our settings, it can be accessed via collabora when editing a file, but only if the flag is set.

The admin settings will be displayed depending on the flag, yes. The user settings however should still show either way. For future versions of Collabora that is, I don't think it works just yet.

Maybe we're talking about different things. But the settings stuff is a bit more involved if I understand the docs correctly: https://sdk.collaboraonline.com/docs/advanced_integration.html#setup-settings-iframe

But that's only needed if we want to integrate the settings within OpenCloud via the settings iFrame. For the settings to display in Collabora itself, there is nothing more to do from our side besides correctly setting IsAdminUser to ensure the admin settings get displayed. Hardcoding it to false would lead to no user having access to the admin settings.