Data loss from a restored folder

[tammi-23]

Describe the bug

It is possible to create two folders with the same name. This leads to a conflict and to strange behavior.

Steps to reproduce

1. Create a Folder A with a File B
2. First Delete the File B
3. Delete Folder A
4. Restore File B from Trashbin (here the Folder from 3. is recreated)
5. Restore Folder A (from Trashbin) and choose "keep both"
6. Click on the Folder with 0 kb (there is the File inside)
7. Go back and click on both folders (they both has the file inside)
8. Rename the empty folder (now one of both folders is not usable after the user is navigating into the folder)

Expected behavior

Both folder are usable or the 2nd folder is created with an other name and there are no conflicts

Actual behavior

Inside one of both folder it is not possible to create files (no new and no upload available)

"Resource not found
We went looking everywhere, but were unable to find the selected resource.
Go to »Personal« page" is displayed

[ScharfViktor]

interesting, web has correct destination with prefix (1) https://host.docker.internal:9200/remote.php/dav/spaces/27e7e0f6-cd60-4ad8-9684-223e0eb7c39f%24c0f63a6e-db39-4156-979b-cbf69af40473/new%20(1)
we need a get second folder a (1)

[ScharfViktor]

tested on demo instance https://demo.opencloud.eu/ OpenCloud 3.5.0 OpenCloud Web UI 4.0.0

Steps:

• create New folder with file
• delete New folder
• create new empty New folder
• restore old New folder from trash using "keep both"

Actual: 2 New folder folders, both are empty. No way to restore file which was inside

Expected: user has two folders: - new empty New folder and restored folder with file New folder (1)

[fschade]

bug is posix fs related, decomposed (export STORAGE_USERS_DRIVER=decomposed) works as designed!

posix fs has another critical error case (which is similar):

Steps

• Create a Folder A with a File B, and File C
• First Delete the File B
• Delete Folder A
• Restore File B from Trashbin (here the Folder from 3. is recreated)
• Restore Folder A (from Trashbin) and choose "keep both"

Result

FILE C is gone

[fschade]

❓

Steps

• Create a Folder A with a File B
• First Delete the File B
• Delete Folder A
• Restore Folder A

Result

Folder A is empty, File B is still in the trash-bin

Q

is it expected that the folder A is empty? In decomposed fs the behavior is the same!