enhance: do not try to create demo users with Keycloak and LDAP enabled

[schweigisito]

If idm/ldap-keycloak.yml is used to deploy Keycload and LDAP service, it doesn't start the opencloud service if the .env file also contains DEMO_USERS=true.

To avoid this conflicting situation, idm/ldap-keycloak.yml disables creating demo users by explicitly setting IDM_CREATE_DEMO_USERS: "false".

[micbar]

Interesting, the variable is needed even when the IDM service is not running? That feels more like a bug in opencloud. @rhafer

[schweigisito]

@rhafer suggested to give it a try using DEMO_USERS: "" within the ldap-keycloak.yml, but this didn't help as the DEMO_USERS=true from the .env file seems to override the .yml file. Therefore I chose the actual service variable IDM_CREATE_DEMO_USERS.

[rhafer]

Interesting, the variable is needed even when the IDM service is not running? That feels more like a bug in opencloud. @rhafer

The variable is also used by the settings service. It checks for that to figure our whether to create the default role assignments. The settings service does not reliably know whether the idm service is enabled or not.

It's debatable whether the settings service should actually evaluate the IDM_CREATE_DEMO_USERS setting (but that would mainly be a naming issue OCIS_CREATE_DEMO_USERS (which we don't have currently) vs IDM_CREATE_DEMO_USERS I rather keep that as it is.

I think the fix is fine. The ldap compose file already forces the OC_ADMIN_USER_ID to be empty, which conflicts with the DEMO_USERS=true from .env. To work correctly, IDM_CREATE_DEMO_USERS needs to be empty as well.

[micbar]

Then please add a code comment with the reasoning.

[rhafer]

@schweigisito I just noticed, that instead of unsetting IDM_CREATE_DEMO_USERS (or setting it to false) you might just want to set SETTINGS_SETUP_DEFAULT_ASSIGNMENTS=false it basically has the same effect but is more to the point and specific to the settings service. If present, SETTINGS_SETUP_DEFAULT_ASSIGNMENTS takes precedence over IDM_CREATE_DEMO_USERS.

Scratch that. SETTINGS_SETUP_DEFAULT_ASSIGNMENTS is already present. Which is weird, something might be wrong with the precedence of the different env vars there. Need to check.

[rhafer]

opencloud-eu/opencloud#1625 this should fix the problem without any changes to the compose file.

[schweigisito]

I will close this PR without merging as the underlying issue has been fixed by opencloud-eu/opencloud#1625