Make site_uuid field on PVSiteMetadata model optional #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 8 8
Lines 321 321
=======================================
Hits 295 295
Misses 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -21,7 +21,7 @@ class PVSiteAPIStatus(BaseModel): | |||
| class PVSiteMetadata(BaseModel): | |||
| """Site metadata""" | |||
|
|
|||
| site_uuid: str = Field(..., description="Unique internal ID for site.") | |||
| site_uuid: Optional[str] = Field(None, description="Unique internal ID for site.") | |||
peterdudfield
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Makes the
site_uuidfield in thePVSiteMetadatamodel optional to support automatic uuid generation by SQLAlchemy. I've also changed the site post endpoint to now not supply a site_uuid (previously from request data).The reason I made the type optional inside
PVSiteMetadatainstead of removing is because the model is used in other endpoints which do have a validsite_uuid.Fixes #62
How Has This Been Tested?
Tested locally via accessing the endpoints. I've changed tests to now try both supplying and not supplying a site uuid when creating a site.
Checklist: