fix: preserve quoted replies in text sends#302
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 16, 2026, 3:17 PM ET / 19:17 UTC. Summary Reproducibility: yes. at source level. The linked issue provides a concrete IPC-delegated DM reproduction, and the current-main stanza-only context path explains the observed successful delivery without a visible quote. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge the exact reviewed head after the full required gate passes, retaining stored-message quote construction, the explicit unsynced-group fallback, and PN/LID normalization coverage. Do we have a high-confidence way to reproduce the issue? Yes at source level. The linked issue provides a concrete IPC-delegated DM reproduction, and the current-main stanza-only context path explains the observed successful delivery without a visible quote. Is this the best way to solve the issue? Yes. Constructing context from the referenced stored message while preserving the documented unsynced-group fallback and normalizing PN/LID participants is the narrowest maintainable repair. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b1eb33538df3. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (4 earlier review cycles)
|
|
🦞🧹
This is fix-only; I will not merge this PR. Re-review progress:
|
|
🦞✅ Source: No actionable findings remain. I removed the repair-loop label and left the PR open for maintainer review and merge. Automerge progress:
|
|
Maintainer repair and exact-head verification complete on The review found and fixed three participant-identity edge cases beyond the original patch:
The branch also adds the Unreleased changelog entry and keeps the documented unsynced-group fallback. Proof:
This checkout has no authenticated WhatsApp account, so I could not independently repeat recipient-side delivery. The linked issue reproduction and the PR's prior redacted direct/IPC proof remain the available live behavior evidence. |
|
Live proof executed on the exact head (10fb41e) with an authenticated store: built
Together with the direct/group/LID/IPC unit matrix and clean hosted CI, landing. Thanks @odilorg. |
Summary
Why
send text --reply-tocurrently emits only a stanza ID and optional participant. WhatsApp accepts and delivers the message but can omit the recipient-side quote box becauseQuotedMessageis absent. Direct-message lookups can also miss silently and still report a successful send.Validation
Closes #301
Thanks @odilorg for the detailed report and live reproduction evidence.