-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable multi-arch builds #86
base: master
Are you sure you want to change the base?
Conversation
1d599d2
to
2dcef29
Compare
6c3d730
to
11e8da5
Compare
This can wait for now. Istio doesn't support ARM64 either, I figured out :P |
bummer :( maybe we can try the Tap plugin instead of Istio in this case |
Upstream istio issue for multi-arch support: istio/istio#26652 |
@kaechele Istio now supports multi-arch builds (they work delightfully on my little RPi cluster 😅). Any chance that pushes the merge of this PR forward? |
I'd be happy to take another look at this, yes. |
@kaechele Just checking on this again. FWIW, I've built multi-arch images for API Clarity and deployed them to my local RPi cluster with the latest multi-arch istio images and it all works like a charm. |
93be8e5
to
26c2e1e
Compare
AMD64 and ARM64 for now. The Tyk plugin depends on the tykio/tyk-plugin-compiler image which does not support any other architecture than AMD64 for now. See TykTechnologies/tyk-build-env#4 ARMv7 was tried but Kong and Tyk do not support it and it may introduce issues due to its 32-bit architecture that we don't want to have to support. Signed-off-by: Felix Kaechele <fkaechel@cisco.com>
26c2e1e
to
5eb881a
Compare
Can we put a conditional in place to skip Tyk plugin build for non-amd64 architectures and list in the caveats that Tyk support is only available on amd64 platforms? |
The skipping should be in place already:
And when building through the Makefile: https://github.com/openclarity/apiclarity/pull/86/files#diff-7eba0837a02c2deea05123583489cc7941f60b687718194ad0b30077c3181c62R22 Also, not sure why the build is failing in CI. Works fine locally. |
AMD64, ARM64 and ARMv7 for now.
The Tyk plugin depends on the tykio/tyk-plugin-compiler image which does
not support any other architecture than AMD64 for now.
See TykTechnologies/tyk-build-env#4
Signed-off-by: Felix Kaechele fkaechel@cisco.com