Add integration test #17
Conversation
garthk
force-pushed
the
add-integration-test
branch
from
0094088
to
39fbe3e
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 28.94% 92.3% +63.36%
==========================================
Files 6 7 +1
Lines 38 39 +1
==========================================
+ Hits 11 36 +25
+ Misses 27 3 -24
Continue to review full report at Codecov.
|
garthk
force-pushed
the
add-integration-test
branch
from
39fbe3e
to
90a0b10
Compare
garthk
force-pushed
the
add-integration-test
branch
from
bfec6e0
to
111ed19
Compare
WIP: promising lead on #11 Still having trouble with unwinding errors
garthk
force-pushed
the
add-integration-test
branch
from
658eca9
to
0eb4d73
Compare
| {:licensir, "~> 0.4.0", only: :test}, | ||
| {:mix_test_watch, "~> 0.8", only: :test}, | ||
| {:opencensus, "~> 0.9.2"}, | ||
| {:opencensus_elixir, "~> 0.4.0"} | ||
| {:opencensus_elixir, "~> 0.4.0"}, |
There was a problem hiding this comment.
In general I prefer to rely on Erlang library itself, as a way to avoid dependency problems, like opencensus_elixir lagging behind.
There was a problem hiding this comment.
I'm with you, but I'm also averse to copy-paste maintenance. The only alternative is dragging the responsibility to the core package, which has had response time problems in the past and excludes any help from Elixir developers. Strikes me as especially odd to do when the problem is had by the Elixir developers e.g. Logger.metadata sync and friendlier ways to get to the contents of the records. Some of that'll go away depending on @tsloughter's new behaviour design. Some won't.
| end | ||
| end | ||
|
|
||
| defmodule MyApp.TracePlug do |
There was a problem hiding this comment.
Why not store all that helper modules in test/support?
Open for feedback before merging. Anyone got any better ideas than spamming
Application.ensure_started/1in thesetup_allto override theruntime: false?I think
SpanandSpanCaptureReporterdemonstrate opencensus-beam/opencensus_elixir#18 well: why should everyone working with spans have to duplicate either? There's enough noise in the test file just getting Absinthe ready.