Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix series filter not being applied to events #1111

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Feb 17, 2025

Includes #980, supersedes #1083.

Should achieve the same thing as #1083, but without reverting to older dependency versions. Meaning clicking on a series name in the series table should bring up the events table with the series filter set. Including #980 as it helps in achieving this.

How to test this

Can be tested as usual. Ideally #980 is tested and merged beforehand.

Arnei added 8 commits November 5, 2024 17:18
When for example setting a filter for the events
table, then switching to the series table and then
switching back to the events table, the previously
set filter will be lost. This change preserves the
filter instead.
We should also be refetching filters when we open
a new table anyway.
Includes opencast#980, supersedes  opencast#1083.

Should achieve the same thing as opencast#1083, but without
reverting to older dependency versions. Meaning
clicking on a series name in the series table
should bring up the events table with the series filter set.
Including opencast#980 as it helps in achieving this.
@Arnei Arnei added the type:bug Something isn't working label Feb 17, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1111

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1111

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1111/2025-02-17_15-12-04/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant