Skip to content

Batch download data pose pickle#249

Merged
carmichaelong merged 3 commits intodevfrom
batchDownloadData_pose-pickle
Aug 19, 2025
Merged

Batch download data pose pickle#249
carmichaelong merged 3 commits intodevfrom
batchDownloadData_pose-pickle

Conversation

@carmichaelong
Copy link
Contributor

Addresses #248

Adds pose pickles to download when using getMotionData() which is used by batchDownloadData.py.

Searching for uses of getMotionData() seems to indicate this should be a safe change. @antoinefalisse would you be able to review (should be a quick review) and indicate any worries of side effects from this?

@antoinefalisse
Copy link
Collaborator

@carmichaelong looking good. Would it make sense to make it optional?

@carmichaelong
Copy link
Contributor Author

It could (for instance it would make sure that existing uses would not be affected), and happy to do that if you think it's helpful (either optional only on getMotionData() or also within batchDownloadData.py).

I figured if a user is downloading from this repository, it's likely this would be useful (and they get it from the web app download already too). Looks like it also doesn't increase download size too much (maybe less than 10%?)

@carmichaelong
Copy link
Contributor Author

@antoinefalisse I finally circled back to this PR. added optional argument with default False to keep default behavior the same. Also adjusted the example to show that this is an option now. Should be a quick review.

@carmichaelong carmichaelong merged commit 0091038 into dev Aug 19, 2025
@carmichaelong carmichaelong deleted the batchDownloadData_pose-pickle branch August 19, 2025 21:46
@carmichaelong
Copy link
Contributor Author

Thanks @antoinefalisse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants