Merged
Conversation
Collaborator
|
@carmichaelong looking good. Would it make sense to make it optional? |
Contributor
Author
|
It could (for instance it would make sure that existing uses would not be affected), and happy to do that if you think it's helpful (either optional only on I figured if a user is downloading from this repository, it's likely this would be useful (and they get it from the web app download already too). Looks like it also doesn't increase download size too much (maybe less than 10%?) |
Contributor
Author
|
@antoinefalisse I finally circled back to this PR. added optional argument with default |
antoinefalisse
approved these changes
Aug 19, 2025
Contributor
Author
|
Thanks @antoinefalisse! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #248
Adds pose pickles to download when using
getMotionData()which is used bybatchDownloadData.py.Searching for uses of
getMotionData()seems to indicate this should be a safe change. @antoinefalisse would you be able to review (should be a quick review) and indicate any worries of side effects from this?