Reduce transform precision to get smaller files and improve loading speed#236
Merged
carmichaelong merged 1 commit intodevfrom Mar 11, 2025
Merged
Reduce transform precision to get smaller files and improve loading speed#236carmichaelong merged 1 commit intodevfrom
carmichaelong merged 1 commit intodevfrom
Conversation
carmichaelong
approved these changes
Feb 28, 2025
Contributor
carmichaelong
left a comment
carmichaelong
left a comment
There was a problem hiding this comment.
LGTM and seems reasonable and safe. Thanks @antoinefalisse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce the size of the files that need to be loaded on the frontend for animating the skeleton, we can decrease the precision of the transform values. This is what this PR is doing. It is only for visualization purposes and it is not "seeable" I don't think, but it decreases file size by a lot which speeds up loading (especially on slow wifi).