Merged
Conversation
Member
There was a problem hiding this comment.
I just reviewed all changes in code and everything seems good. I especially liked that you added specific permission exceptions.
While running tests I found a permission denied error, related to a temp file generated locally (I shared with you on slack). It's probably just a problem with my environment but I would like to know your opinion.
I will be doing more tests tomorrow.
Contributor
Author
|
thanks @AlbertoCasasOrtiz. i didn't see the temp file issue during my testing. feel free to look into it, but given what you've reviewed, i'm going to merge this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AlbertoCasasOrtiz addresses #263 (and #261)