Skip to content

Conversation

@szautkin
Copy link

No description provided.

jburke-cadc and others added 30 commits October 6, 2025 09:42
@at88mph
Copy link
Member

at88mph commented Feb 2, 2026

Hi @szautkin ,
I can run the UI and ADES from the deploy.sh script as described. That's good.

I can see that the rafts/api/validator/ades/Python was taken from the IAU-ADES GitHub. Rather than doing that, let's containerize it using their published PyPi:

  • Remove the rafts/api/validator/ades/Python inclusion
  • Create a Dockerfile for the iau-ades (https://pypi.org/project/iau-ades/) package they publish to ensure we get updates
  • For the frontend Dockerfile, which I think will be what gets deployed in Production, can we just run a node build in a layer, and then the final layer can be an nginx deploy?

@brianmajor
Copy link
Member

@szautkin - how does suggestion for ADES sound?

Also, are the two PRs in conflict? You mentioned maybe Arati could review one? The other one I guess?

@at88mph
Copy link
Member

at88mph commented Feb 9, 2026

Also, for this PR, there is the doi folder included. I think this is just a duplicate of the other PR (#19 ), and so could be removed from this one.

Copy link
Member

@at88mph at88mph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @szautkin. A couple of broad comments:

@szautkin szautkin closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants