-
Notifications
You must be signed in to change notification settings - Fork 1
add compartment_set in reports section + example entry for compartment set report #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let you decide about my comment. it is not blocking
source/sonata_simulation.rst
Outdated
.. code-block:: json | ||
"compartment_sets_file": "circuit/compartment_sets.json" | ||
"compartment_sets_file": "./circuit/compartment_sets.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just verified: it works with:
./compartment_sets.json
compartment_sets.json
/<full-path>/compartment_sets.json
I dunno if you want to updte this to make it explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just verified: it works with:
Verified with what?
As long as the relative path is resolvable with the base directory being the one where the simulation config is, it should be find-able. libsonata should return an absolute path to the file - if it doesn't it should be fixed.
For paths within config files, it's recommend never to use absolute paths, as that means the circuit isn't portable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with a test I had under my hands
Ofc it is better relative. However, the full path is possible too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check with @ilkilic what openbraininstitute/BlueCelluLab#33 (comment) in bluecellulab when I don't give "./" in compartment_set_file entry.
If you're using libsonata to parse the files; it's a bug that would need to be fixed, imo; both ./
and <nothing>
should be equivalent, and return the full path.
Solves #12.