Skip to content

Conversation

darshanmandge
Copy link
Contributor

Solves #12.

@darshanmandge darshanmandge self-assigned this Sep 12, 2025
cattabiani
cattabiani previously approved these changes Sep 15, 2025
Copy link
Contributor

@cattabiani cattabiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you decide about my comment. it is not blocking

.. code-block:: json
"compartment_sets_file": "circuit/compartment_sets.json"
"compartment_sets_file": "./circuit/compartment_sets.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just verified: it works with:
./compartment_sets.json
compartment_sets.json
/<full-path>/compartment_sets.json

I dunno if you want to updte this to make it explicit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just verified: it works with:

Verified with what?

As long as the relative path is resolvable with the base directory being the one where the simulation config is, it should be find-able. libsonata should return an absolute path to the file - if it doesn't it should be fixed.
For paths within config files, it's recommend never to use absolute paths, as that means the circuit isn't portable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with a test I had under my hands

Ofc it is better relative. However, the full path is possible too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both for the clarification! I will check with @ilkilic what happens in bluecellulab when I don't give "./" in compartment_set_file entry.
I made the text to make the example entry similar to what we have for the network example above. Is this fine with you both?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check with @ilkilic what openbraininstitute/BlueCelluLab#33 (comment) in bluecellulab when I don't give "./" in compartment_set_file entry.

If you're using libsonata to parse the files; it's a bug that would need to be fixed, imo; both ./ and <nothing> should be equivalent, and return the full path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants