save entitysdk entities #460
Open
+602
−489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinging @darshanmandge on all my unmerged PRs |
darshanmandge
force-pushed
the
ion-channel-entitysdk
branch
from
12c33f5 to
f040404
Compare
chr-pok
reviewed
Oct 30, 2025
There was a problem hiding this comment.
There is a notebook examples/A-.../ion_channel_modeling.ipynb @chr-pok
Currently failing when the useIon model is built within the task
| grid_scan.execute() | ||
|
|
||
| with pytest.raises(ValueError, match=re.escape("Unknown properties: [np.str_('INVALID')]")): | ||
| with pytest.raises(ValueError, match=r"Unknown properties:.*INVALID"): |
There was a problem hiding this comment.
I changed this is in main recently to:
[np.str_('INVALID')]
Do we know why this change was needed? It looks like connectome utilities hasn't been changed @chr-pok
There was a problem hiding this comment.
No idea! I cannot reproduce locally. I suppose some dependencies that are used by connectome utilities have changed perhaps.
There was a problem hiding this comment.
Ok, then this is a good fix for now I think!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has to be merged once this entitysdk PR has been merged: openbraininstitute/entitysdk#139