Generic launch_task_for_single_config_asset script #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-isbister
changed the title
james-isbister
changed the title
jdcourcol
reviewed
Oct 20, 2025
| db_client = Client(token_manager=token, project_context=project_context) | ||
|
|
||
| run_task_for_single_config_asset( | ||
| entity_type=entity_type, |
Contributor
There was a problem hiding this comment.
I think we should have a return code.
And a convention for task manager (@eleftherioszisis ) , what do we do with the return code.
Collaborator
Author
There was a problem hiding this comment.
Can this wait for a future PR. See comment below
Contributor
There was a problem hiding this comment.
sure, but this is important. no return code means we don't know if that was a success or not , so that is not great.
Collaborator
Author
There was a problem hiding this comment.
Ok, I'll add 0 for success and 1 for an error then for now
jdcourcol
reviewed
Oct 20, 2025
jdcourcol
reviewed
Oct 20, 2025
Collaborator
Author
|
I've addressed the comments @jdcourcol @eleftherioszisis @pgetta Except for the return code. Can you recommend a return code for the script? Or we leave it for another PR? |
eleftherioszisis
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic script "launch_task_for_single_config_asset.py", which takes as inputs:
entity_type_str
entity_id
asset_id
token
lab_id
project_id
The script downloads into memory the specified asset which should be the obi_one SingleConfig json (for a single coordinate in a scan).
The script then determines and executes the corresponding task
For example, this would be used to execute a single circuit extraction or single ion channel optimization (where the campaign and single configs have already been generated and registered to entitycore by a call to the obi-one service).
This script could be used by @pgetta 's service and task manager. This can be adapted, but in the short term this is needed for the ion channel modeling service @AurelienJaquier
Not sure if the passing of the token is appropriate