State sharing #507
Open
State sharing #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonderPG
commented
Sep 12, 2025
Comment on lines
-128
to
-130
| from neuroagent.tools.obione_generatesimulationsconfig import ( | ||
| GenerateSimulationsConfigTool, | ||
| ) |
There was a problem hiding this comment.
I had an annoying cyclic dependency that I could resolve only by not importing this tools in the __init__. If you have a better idea let me know. The dependency is
conftest -> neuroagent.app.dependencies -> neuroagent.agent_routine -> neuroagent.new_types -> neuroagent.tools.autogenerated_types.obione -> neuroagent.tools.__init__ -> neuroagent.tools.obione_generatesimulationsconfig -> new_types
jankrepl
reviewed
Sep 12, 2025
Comment on lines
+65
to
+95
| >({ | ||
| smc_simulation_config: { | ||
| type: "SimulationsForm", | ||
| timestamps: {}, | ||
| stimuli: {}, | ||
| recordings: {}, | ||
| neuron_sets: {}, | ||
| synaptic_manipulations: {}, | ||
| initialize: { | ||
| type: "SimulationsForm.Initialize", | ||
| circuit: { | ||
| type: "CircuitFromID", | ||
| id_str: "", | ||
| }, | ||
| node_set: { | ||
| block_dict_name: "", | ||
| block_name: "", | ||
| type: "NeuronSetReference", | ||
| }, | ||
| simulation_length: 1000, | ||
| extracellular_calcium_concentration: 1.1, | ||
| v_init: -80, | ||
| random_seed: 1, | ||
| }, | ||
| info: { | ||
| type: "Info", | ||
| campaign_name: "name", | ||
| campaign_description: "description", | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I would store this default at the top of the file and just link here. Of course highly subjective.
jankrepl
reviewed
Sep 12, 2025
Comment on lines
+106
to
+108
| if base_simulation_form is None: | ||
| raise ValueError( | ||
| f"To edit a Small Microcircuit Simulation, first navigate to {self.metadata.entity_frontend_url + '/simulate?&s=new&t=small-microcircuit'}, pick a circuit, click 'New Simulation' and call the tool again." |
There was a problem hiding this comment.
Discussed privately. Another option is to set base_simulation_form={}. Your call
jankrepl
reviewed
Sep 12, 2025
| description: ClassVar[ | ||
| str | ||
| ] = """This tool generates JSON configurations for simulations based on natural language descriptions. It takes a user's request for a configuration (including modifications to existing configs) and uses an LLM with structured output to produce the corresponding JSON. | ||
| ] = """This tool generates JSON configurations for simulations based on natural language descriptions. It accepts both complete configuration specifications and modification requests for existing configurations, using an LLM with structured output to produce the corresponding JSON. |
There was a problem hiding this comment.
Any chance we could advise the LLM not to "copy paste" the raw json patch from the tool output to the ai-message.
See what it did
There was a problem hiding this comment.
First time I see it. Sure I will prompt it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #489
How it works
The backend is adjusted to accept descriptions of full simulation campaigns or incremental changes. The frontend passes the current simulation config in the request body which the backend recovers. The final simulation json is split into json patches that are returned in the tool output. The frontend is responsible for applying them to their state.
The frontend shows a button next to relevant tools (smc simulation config in this case) which opens a sidebar. When the tool call is done, the JSON displayed updates. You can also modify it directly in the frontend, the changes will be seen by the backend on the next request
Disclaimer
obione-generatesimulationsconfigto see the button appear and to be able to open the sidebar. It currently shows only the simulation config json, not the whole state.The frontend is far from perfect, but tracking correctly this json and its diffs (tool + frontend) is too much of a task for this ticket imo. Feel free to disagree and make changes !