Skip to content

Tool call + content - UI change #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Tool call + content - UI change #382

wants to merge 6 commits into from

Conversation

BoBer78
Copy link
Collaborator

@BoBer78 BoBer78 commented Jun 25, 2025

closes #364

@BoBer78 BoBer78 changed the title working prototype Tool call + content - UI change Jun 25, 2025
@BoBer78 BoBer78 marked this pull request as ready for review June 26, 2025 10:07
@BoBer78
Copy link
Collaborator Author

BoBer78 commented Jun 26, 2025

If you want to try it you can use the Claude 3 : haiku. All the Claude models often "reason" in the text parts.
Here is a picture of the new UI :
image
Fell free to disagree with some of the design changes.
Two things to note is that now :

  • the plots appear with their respective tool
  • the tool are now pop-ups and do not expand in the chat anymore

Copy link
Collaborator

@WonderPG WonderPG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside a couple of comments discussed privately, works and looks great thank you !

@@ -64,7 +49,7 @@ export function ChatMessagesInsideThread({
messages.map((msg) => (msg.id === messageId ? updater(msg) : msg)),
);
};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover console.log

@jankrepl
Copy link
Collaborator

jankrepl commented Jun 27, 2025

The UI looks great @BoBer78! One thing that is a bit iffy is the behavior when one keeps the tool dialog open and then starts scrolling the chat. Some possible solutions

  • No action
  • Automatically close when the user starts scrolling the chat. Might be the way to go since the dialog itself does not have any close button and to close it you would need to find the element in the original chat. EDIT - I just realized that it does not stay on the screen all the time. I see I see. Maybe note that big of a deal.
  • Keep it open but maybe make it behave a bit nicer - like for example what I don't like is that it can overlay the text input area. I would not allow it to move outside the chat area.
Screen.Recording.2025-06-27.at.10.52.27.mov

One "regression" (but it is not a problem) is that one cannot have 2+ tool calls open at the same time. But whatever. If you guys think this is better than before I am not going to block it. Just my regular comment. Cursor + Claude have the same UI as we have on main.

@jankrepl
Copy link
Collaborator

Anyway, it works great:))) Thanks @BoBer78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for a cleaner content + tool_call
3 participants